Open
Conversation
- Updated TIMESTAMP and TIME types to truncate milliseconds instead of
rounding
- Changed the regex so that fractions of seconds will be read exactly
for TIME, TIMESTAMP, and LONGDATE types
- The fractions are truncated to nearest millisecond for TIME and
TIMESTAMP, and nanosecond for LONGDATE
- Added some unit tests for truncating DATETIME types
- Updated integration tests for DFV 4 types to also be run on DFV 1
- Updated the spatial types and boolean integration tests to also be run on DFV 1 (BINTEXT DFV6 integration tests were updated in the previous commit) - Wrote a comment about a BOOLEAN behaviour change in DFV 7, where the empty string '' will result in null in DFV 7 but in DFV 1 it results in false
IanMcCurdy
requested changes
Apr 24, 2025
Collaborator
IanMcCurdy
left a comment
IanMcCurdy
left a comment
There was a problem hiding this comment.
Change looks good. After you open a bugzilla for the truncation/rounding issue just add the bug number into the commit description
- Removed the comment about the behaviour change in DFV 7 which
affects empty string inputs for BOOLEAN.
- The behaviour will be clear in the test change for BOOLEAN
in a separate pull request
Bug: 342310
- Updated the call of setUpTableRemoteDB in the FIXED integration tests to match with new consolidated setUpTable introduced in fix TIMESTAMP and TIME commit to simplify the data type integration tests
IanMcCurdy
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: 342310